On 26 March 2018 at 10:08, Lionel Landwerlin
<lionel.g.landwerlin@xxxxxxxxx> wrote:
> This will allow use to program the hardware based on the stream's
> properties in a later commit.
I couldn't see where we need this? Regardless, operating on the stream
itself makes more sense to me.
>
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@xxxxxxxxx>
> ---
> drivers/gpu/drm/i915/i915_drv.h | 3 ++-
> drivers/gpu/drm/i915/i915_perf.c | 12 +++++++-----
> 2 files changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index f1a38c92bb1f..1169f0a5261f 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1515,7 +1515,8 @@ struct i915_oa_ops {
> /**
> * @oa_enable: Enable periodic sampling
> */
> - void (*oa_enable)(struct drm_i915_private *dev_priv);
> + void (*oa_enable)(struct drm_i915_private *dev_priv,
> + const struct i915_perf_stream *stream);
Ditto. We can drop the dev_priv, and can we maybe also do the same for
oa_disable?
Reviewed-by: Matthew Auld <matthew.auld@xxxxxxxxx>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
