Re: [PATCH 01/11] drm/i915/perf: pass stream to enable metric set vfuncs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 26 March 2018 at 20:21, Matthew Auld <matthew.william.auld@xxxxxxxxx> wrote:
> On 26 March 2018 at 10:08, Lionel Landwerlin
> <lionel.g.landwerlin@xxxxxxxxx> wrote:
>> We want to use some of the properties of the perf stream to program
>> the hardware in a later commit.
>>
>> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@xxxxxxxxx>
>> ---
>>  drivers/gpu/drm/i915/i915_drv.h  |  2 +-
>>  drivers/gpu/drm/i915/i915_perf.c | 10 ++++++----
>>  2 files changed, 7 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
>> index 800230ba1c3b..f1a38c92bb1f 100644
>> --- a/drivers/gpu/drm/i915/i915_drv.h
>> +++ b/drivers/gpu/drm/i915/i915_drv.h
>> @@ -1504,7 +1504,7 @@ struct i915_oa_ops {
>>          * disabling EU clock gating as required.
>>          */
>>         int (*enable_metric_set)(struct drm_i915_private *dev_priv,
>> -                                const struct i915_oa_config *oa_config);
>> +                                const struct i915_perf_stream *stream);
>
> We can just drop dev_priv, since we have stream->dev_priv.
>
> With that:
> Reviewed-by: Matthew Auld <matthew.auld@xxxxxxxxx>

Actually can we also do the same thing for disable_metric_set, for symmetry?
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux