On Mon, 26 Feb 2018, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote: > Quoting Jani Nikula (2018-02-26 10:42:40) >> On Tue, 20 Feb 2018, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote: >> > We make use of unsafe kernel parameters in igt, which generates a >> > warning and taints the kernel. The warning is unhelpful as we then need >> > to filter it out again, so kill it at source. >> >> Is your goal to upstream this or what? > > First asking if we see merit in this. If so, I can rewrite the commitmsg > to emphasise that this is a direct result of user behaviour and so > emitting a WARN is over the top. However, the counter argument is that > this sets a kernel taint, so shouldn't it warn as well? I erred on the side of ensuring the reason for tainting doesn't go unnoticed when I added that. But I don't think the logging level was ever discussed, it's just what I thought best at the time. I don't think I care as long as it stays below debug level. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
