Re: [PATCH] drm/i915: fix the issue DP-1 not working in guest

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jani, 

In GVT (virtualization) environment, it only can use DP.  Therefore, we want to enable Port A as DP so that display panel on Port A can be used by GVT. 

Best regard 

Mustamin


-----Original Message-----
From: Jani Nikula [mailto:jani.nikula@xxxxxxxxxxxxxxx] 
Sent: Tuesday, February 20, 2018 7:35 PM
To: Mustaffa, Mustamin B <mustamin.b.mustaffa@xxxxxxxxx>; intel-gfx@xxxxxxxxxxxxxxxxxxxxx
Cc: Mustaffa, Mustamin B <mustamin.b.mustaffa@xxxxxxxxx>; Anuar, Nuhairi <nuhairi.anuar@xxxxxxxxx>
Subject: Re:  [PATCH] drm/i915: fix the issue DP-1 not working in guest

On Tue, 20 Feb 2018, Mustamin B Mustaffa <mustamin.b.mustaffa@xxxxxxxxx> wrote:
> In GVT guest, when port A is DP, i915 will force it as an EDP panel, 
> which will cause DP-1 not working in GVT guest.
> This patch fixed this issue by check intel_vgpu_active() in 
> intel_ddi_compute_config().

Just repeating Ville's question from last June that went unanswered [1], "And why exactly are you trying to register DP on port A?"

BR,
Jani.

[1] http://mid.mail-archive.com/20170614133842.GM12629@xxxxxxxxx

>
> Signed-off-by: Min He <min.he@xxxxxxxxx>
> Signed-off-by: Nuhairi Anuar <nuhairi.anuar@xxxxxxxxx>
> Signed-off-by: Mustamin B Mustaffa <mustamin.b.mustaffa@xxxxxxxxx>
> ---
>  drivers/gpu/drm/i915/intel_ddi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c 
> b/drivers/gpu/drm/i915/intel_ddi.c
> index db92a26..9f5e85c 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -2720,7 +2720,7 @@ static bool intel_ddi_compute_config(struct intel_encoder *encoder,
>  	enum port port = encoder->port;
>  	int ret;
>  
> -	if (port == PORT_A)
> +	if (port == PORT_A && !intel_vgpu_active(dev_priv))
>  		pipe_config->cpu_transcoder = TRANSCODER_EDP;
>  
>  	if (intel_crtc_has_type(pipe_config, INTEL_OUTPUT_HDMI))

--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux