Re: [PATCH] drm: move read_domains and write_domain into i915

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 16.02.2018 um 13:30 schrieb Chris Wilson:
Quoting Christian König (2018-02-16 12:27:28)
Am 16.02.2018 um 11:18 schrieb Chris Wilson:
Quoting Christian König (2018-02-16 09:31:23)
i915 is the only driver using those fields in the drm_gem_object
structure, so they only waste memory for all other drivers.

Move the fields into drm_i915_gem_object instead and patch the i915 code
with the following sed commands:

sed -i "s/obj->base.read_domains/obj->read_domains/g" drivers/gpu/drm/i915/*.c drivers/gpu/drm/i915/*/*.c
sed -i "s/obj->base.write_domain/obj->write_domain/g" drivers/gpu/drm/i915/*.c drivers/gpu/drm/i915/*/*.c
s/uint32_t/u16/ and plonk them next to
       unsigned int cache_dirty:1;
Sure, no problem. Should I push this to drm-misc or should it go in
using some Intel tree?
How desperate are you? Can you wait until rc5 for the fields to
disappear?

I think this should be via drm-intel-next-queued, since nobody else has
a dependency. Otoh, you want it in early to ensure nobody else picks up
a dependency ;)

Well it's probably in there for years and nobody noticed, so I think we can wait a bit longer as well :)

Going to send a V2 with your comments addressed soon.

Christian.

-Chris

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux