On 12/1/2017 12:40 AM, Chris Wilson wrote:
Quoting Patchwork (2017-11-30 18:37:38)
== Series Details ==
Series: series starting with [1/6] drm/i915/huc: Move firmware selection to init_early
URL : https://patchwork.freedesktop.org/series/34694/
State : failure
WARNING: Long output truncated
What's CI is trying to tell us there at the end is that we have a NULL
deref in guc_doorbell_destroy if we fail to load the guc firmware. So we
need to double check all the guc_init_submission failure paths.
guc_submission_disable in intel_uc_fini_hw is gated by module param still.
either we need to migrate to internal submission init state or update
enable_guc=0 on guc init
failure when we have set auto option.
Taking sanitization past guc_fetch and making intel_uc_fw_is_selected
rely on fetch_status looks
best option though because if we want to return -EIO then i915 load
should mark as device init
failure which isn't happening currently (leading to reset path failures
as well)
I'm still on the fence as to whether forcing -EIO on init failure is a
good plan. We still have to go through all the reset code, teaching it
that it's ok to fail (or at least the failure is expected and to be
quiet, as we've already already the user to it).
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
