Re: [PATCH] drm/i915: Disable THP until we have a GPU read BW W/A

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2017-11-27 at 13:36 +0000, Rantala, Valtteri wrote:
> > -----Original Message-----
> > From: Joonas Lahtinen [mailto:joonas.lahtinen@xxxxxxxxxxxxxxx]
> > Sent: Monday, November 27, 2017 11:13 AM
> > To: Intel graphics driver community testing & development <intel-
> > gfx@xxxxxxxxxxxxxxxxxxxxx>
> > Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>; Auld, Matthew
> > <matthew.auld@xxxxxxxxx>; Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>; Jani
> > Nikula <jani.nikula@xxxxxxxxxxxxxxx>; Vivi, Rodrigo <rodrigo.vivi@xxxxxxxxx>;
> > Rantala, Valtteri <valtteri.rantala@xxxxxxxxx>; Tamminen, Eero T
> > <eero.t.tamminen@xxxxxxxxx>
> > Subject: [PATCH] drm/i915: Disable THP until we have a GPU read BW W/A
> > 
> > We seem to be missing some W/A for 2M pages and are getting a hit on raw
> > GPU read bandwidths (even 30%) even though the GPU write bandwidths
> > improve (even 10%).
> > 
> > For now, disable THP, which is our only practical source of 2M pages until we
> > have a W/A for the issue.
> > 
> > v2:
> > - Be explicit that we talk about GPU bandwidths (Eero)
> > - s/deny/never/ because that's why (Chris)
> > 
> > Reported-by: Valtteri Rantala <valtteri.rantala@xxxxxxxxx>
> > Fixes: b901bb89324a ("drm/i915/gemfs: enable THP")
> > Signed-off-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
> > Cc: Matthew Auld <matthew.auld@xxxxxxxxx>
> > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > Cc: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>
> > Cc: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>
> > Cc: Valtteri Rantala <valtteri.rantala@xxxxxxxxx>
> > Cc: Eero Tamminen <eero.t.tamminen@xxxxxxxxx>
> > Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > Reviewed-by: Matthew Auld <matthew.auld@xxxxxxxxx>
> 
> Tested-by: Valtteri Rantala <valtteri.rantala@xxxxxxxxx>

I'm merging the patch, thanks for the report, reviews and testing!

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux