From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
Averaging with the previous sample brings a small statistical improvement
to sampling counters, but can leek a little bit of state from a current
client to the next which mulls the border between past and present for
observing clients.
This is because on event enable clients record the current counter value
and use it as reference, but with rapid off-on event cycles, and due the
delayed nature of sampling timer self-disarm, previous sample value does
not get cleared under these circumstances.
Solution is to stop averaging with the previous sample. This has a small
downside of losing some precision with short and spiky signals, but the
alternatives look too complicated for the benefit.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
Cc: Sagar Arun Kamble <sagar.a.kamble@xxxxxxxxx>
---
drivers/gpu/drm/i915/i915_pmu.c | 29 ++---------------------------
drivers/gpu/drm/i915/i915_pmu.h | 1 -
2 files changed, 2 insertions(+), 28 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_pmu.c b/drivers/gpu/drm/i915/i915_pmu.c
index 5170a46893d7..685aef1d81b9 100644
--- a/drivers/gpu/drm/i915/i915_pmu.c
+++ b/drivers/gpu/drm/i915/i915_pmu.c
@@ -181,12 +181,7 @@ static bool grab_forcewake(struct drm_i915_private *i915, bool fw)
static void
update_sample(struct i915_pmu_sample *sample, u32 unit, u32 val)
{
- /*
- * Since we are doing stochastic sampling for these counters,
- * average the delta with the previous value for better accuracy.
- */
- sample->cur += div_u64(mul_u32_u32(sample->prev + val, unit), 2);
- sample->prev = val;
+ sample->cur += mul_u32_u32(val, unit);
}
static void engines_sample(struct drm_i915_private *dev_priv)
@@ -262,31 +257,13 @@ static void frequency_sample(struct drm_i915_private *dev_priv)
}
}
-static void pmu_init_previous_samples(struct drm_i915_private *i915)
-{
- struct intel_engine_cs *engine;
- enum intel_engine_id id;
- unsigned int i;
-
- for_each_engine(engine, i915, id) {
- for (i = 0; i < ARRAY_SIZE(engine->pmu.sample); i++)
- engine->pmu.sample[i].prev = 0;
- }
-
- for (i = 0; i < ARRAY_SIZE(i915->pmu.sample); i++)
- i915->pmu.sample[i].prev = i915->gt_pm.rps.idle_freq;
-}
-
static enum hrtimer_restart i915_sample(struct hrtimer *hrtimer)
{
struct drm_i915_private *i915 =
container_of(hrtimer, struct drm_i915_private, pmu.timer);
- if (!READ_ONCE(i915->pmu.timer_enabled)) {
- pmu_init_previous_samples(i915);
-
+ if (!READ_ONCE(i915->pmu.timer_enabled))
return HRTIMER_NORESTART;
- }
engines_sample(i915);
frequency_sample(i915);
@@ -867,8 +844,6 @@ void i915_pmu_register(struct drm_i915_private *i915)
hrtimer_init(&i915->pmu.timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
i915->pmu.timer.function = i915_sample;
- pmu_init_previous_samples(i915);
-
for_each_engine(engine, i915, id)
INIT_DELAYED_WORK(&engine->pmu.disable_busy_stats,
__disable_busy_stats);
diff --git a/drivers/gpu/drm/i915/i915_pmu.h b/drivers/gpu/drm/i915/i915_pmu.h
index e209783a4c5f..40c154d13565 100644
--- a/drivers/gpu/drm/i915/i915_pmu.h
+++ b/drivers/gpu/drm/i915/i915_pmu.h
@@ -41,7 +41,6 @@ enum {
struct i915_pmu_sample {
u64 cur;
- u32 prev;
};
struct i915_pmu {
--
2.14.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
