On Thu, Nov 09, 2017 at 10:23:44AM +0000, Chris Wilson wrote: > Quoting Chris Wilson (2017-11-09 10:21:41) > > vm_free_page() may call down into set_pages_array_wb() (which itself > > sleeps, on x86 at least) but only if on !llc and the caches overflow. > > Since this is unlikely, we only rarely trigger the error in practice, > > and so to make CI detection of this sleeping bug possible we want to > > mark the common vm_free_page() as a potential sleep. > > > > References: https://bugs.freedesktop.org/show_bug.cgi?id=103638 > > Suggested-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> > > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > > Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> > > Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> > > Cc: Matthew Auld <matthew.william.auld@xxxxxxxxx> > > The real test ofc is whether this reports an error from CI. Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx> But if it indeed blows up on CI I think it'd be good to fix first, then apply the more aggressive debug check. Otherwise CI and Marta will be on fire :-) -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
