Re: Pushing commits to drm-intel-next-queued and questions about CI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hans,

On Fri, Nov 03, 2017 at 10:41:55AM +0000, Hans de Goede wrote:
> Hi Daniel,
> 
> A while ago I was granted commit rights to the drm-intel repo.
> So far I've not used these, but since no-one seems to be
> pushing these 2 sets, I guess now might be a good time to
> learn how to push things myself.
> 
> I'm talking about these 2 patch-sets:
> 
> https://patchwork.freedesktop.org/series/32274/

For this one we got the ack from Ingo, but I missed the reviewed-by
on the second one that is the i915 part of it.
Do we need it or just that ack was enough for both patches?

> https://patchwork.freedesktop.org/series/32288/
> 
> Both have all the necessary reviews, etc.
> 
> The first series triggers some new warnings in Fi.CI.IGT,
> looking at the history of the tests triggering new warnings,
> e.g. I see a "new" warning on kbl in:
> https://intel-gfx-ci.01.org/tree/drm-tip/igt@kms_busy@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
> it seems that some tests simply sometimes trigger some warnings,
> if that is the case can I ignore these ?

Ideally it is good to retest. CI is getting better day by day.
So if you run today and it was yesterday's false positive it will
probably not be there anymore.

> 
> Also it seems that the 3261 tip chosen to run the tests against
> was a poor one according to the per test histories many
> tests were skipped against it. How can I reschedule tests?

Or someone with patchwork admin can do that for you
or you need to resend the series... but...

> 
> Likewise the 2nd patchset failed 1 test in
> Fi.CI.BAT, which seems unrelated to the patch-set.

... I just triggered both retests for you here...

> 
> This means the other tests never ran, so I guess
> I should reschedule the tests for this set.
> 
> Given that all the patches have been reviewed and acked can
> I simply push these to drm-intel-next-queued once the
> tests results are sorted out?

If you have permission and if you are follow the guidelines
and docs, you know what you are doing ;)

Thanks,
Rodrigo.

> 
> Regards,
> 
> Hans
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux