On Tue, 2017-09-26 at 14:01 +0200, Daniel Vetter wrote: > On Mon, Sep 25, 2017 at 02:48:41PM +0300, Jani Nikula wrote: > > On Mon, 25 Sep 2017, Petri Latvala <petri.latvala@xxxxxxxxx> wrote: > > > [[ a != b ]] is a bashism. As it's just comparing $1 to an empty > > > string, use -n with a normal [ ]. > > > > > > /bin/sh is dash in CI. > > > > There's probably /bin/bash around anyway, but I'm tired of fighting the > > fight. So never mind about that. > > Yeah, let's just switch to /bin/bash and stop bothering with dash. At > least I don't see any value in trying to be posix compliant, we're not > going to run on anything that doesn't have bash anyway. I'm actively running I-G-T with busybox sh, so please cut with the /bin/bash stuff, it's not that hard to be POSIX compliant. Original patch is; Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
