Re: [PATCH 1/2] drm/i915: Fix a typo in i915_ppat_get()

["Wang, Zhi A" <zhi.a.wang@xxxxxxxxx>]

Oops. So it’s like we have to create some entries with same cache attributes before perfect match test case.

 

From: Widawsky, Benjamin
Sent: Friday, September 15, 2017 8:02 AM
To: Wang, Zhi A <zhi.a.wang@xxxxxxxxx>; Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>; Vivi, Rodrigo <rodrigo.vivi@xxxxxxxxx>
Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; intel-gvt-dev@xxxxxxxxxxxxxxxxxxxxx; joonas.lahtinen@xxxxxxxxxxxxxxx; zhenyuw@xxxxxxxxxxxxxxx
Subject: Re: [PATCH 1/2] drm/i915: Fix a typo in i915_ppat_get()

 

Juvenile no 00

 

 

-------- Original message --------

From: "Wang, Zhi A" <zhi.a.wang@xxxxxxxxx>

Date: 9/14/17 8:03 PM (GMT-08:00)

To: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>, "Vivi, Rodrigo" <rodrigo.vivi@xxxxxxxxx>

Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx, intel-gvt-dev@xxxxxxxxxxxxxxxxxxxxx, joonas.lahtinen@xxxxxxxxxxxxxxx, zhenyuw@xxxxxxxxxxxxxxx, "Widawsky, Benjamin" <benjamin.widawsky@xxxxxxxxx>

Subject: RE: [PATCH 1/2] drm/i915: Fix a typo in i915_ppat_get()

 

Sorry for the trouble. It's because we have 4 different entries with different attributes and every time we match an entry by cache attribute, we got a perfect match...

-----Original Message-----
From: Chris Wilson [mailto:chris@xxxxxxxxxxxxxxxxxx]
Sent: Thursday, September 14, 2017 9:41 PM
To: Vivi, Rodrigo <rodrigo.vivi@xxxxxxxxx>; Wang, Zhi A <zhi.a.wang@xxxxxxxxx>
Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; intel-gvt-dev@xxxxxxxxxxxxxxxxxxxxx; joonas.lahtinen@xxxxxxxxxxxxxxx; zhenyuw@xxxxxxxxxxxxxxx; Widawsky, Benjamin <benjamin.widawsky@xxxxxxxxx>
Subject: Re: [PATCH 1/2] drm/i915: Fix a typo in i915_ppat_get()

Quoting Rodrigo Vivi (2017-09-14 18:36:49)
>
> well, I wouldn't call this as a typo.
> This is a logic fix and deserves a better subject a proper commit
> message an also fixes tag:

It should work either way, just the bug doesn't allow reuse.

The question to ask is why didn't the selftest pick this up? It passes on bdw...
-Chris

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx