Sorry for the trouble. It's because we have 4 different entries with different attributes and every time we match an entry by cache attribute, we got a perfect match... -----Original Message----- From: Chris Wilson [mailto:chris@xxxxxxxxxxxxxxxxxx] Sent: Thursday, September 14, 2017 9:41 PM To: Vivi, Rodrigo <rodrigo.vivi@xxxxxxxxx>; Wang, Zhi A <zhi.a.wang@xxxxxxxxx> Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; intel-gvt-dev@xxxxxxxxxxxxxxxxxxxxx; joonas.lahtinen@xxxxxxxxxxxxxxx; zhenyuw@xxxxxxxxxxxxxxx; Widawsky, Benjamin <benjamin.widawsky@xxxxxxxxx> Subject: Re: [PATCH 1/2] drm/i915: Fix a typo in i915_ppat_get() Quoting Rodrigo Vivi (2017-09-14 18:36:49) > > well, I wouldn't call this as a typo. > This is a logic fix and deserves a better subject a proper commit > message an also fixes tag: It should work either way, just the bug doesn't allow reuse. The question to ask is why didn't the selftest pick this up? It passes on bdw... -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx