On Thu, Sep 14, 2017 at 11:04:14AM -0700, Jordan Justen wrote:
> On 2017-09-11 10:24:56, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> >
> > autotools installs the tests into $libexecdir. Make meson do the same.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> > ---
> > tests/meson.build | 10 ++++++++--
> > 1 file changed, 8 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/meson.build b/tests/meson.build
> > index 4dd5a9c9d4c7..1f98f2a02bb9 100644
> > --- a/tests/meson.build
> > +++ b/tests/meson.build
> > @@ -255,13 +255,19 @@ if alsa.found() and gsl.found()
> > test_deps += alsa
> > endif
> >
> > +libexecdir = join_paths(get_option('prefix'), get_option('libexecdir'), 'intel-gpu-tools')
> > +
> > foreach prog : test_progs
> > executable(prog, prog + '.c',
> > - dependencies : test_deps)
> > + dependencies : test_deps,
> > + install_dir : libexecdir,
> > + install : true)
> > endforeach
> >
> > executable('testdisplay', ['testdisplay.c', 'testdisplay_hotplug.c'],
> > - dependencies : test_deps)
> > + dependencies : test_deps,
> > + install_dir : libexecdir,
> > + install : true)
>
> I noticed indentation alignment issues, like this one, in many of the
> patches. (Often when adding 'install : true')
>
> Can you review and fix the alignment on all patches?
Looks like there's something fishy going on with emacs meson-mode. It
uses spaces to indent one line and for other lines it uses tabs.
Hmm. OK, so it looks like if there's already 8 spaces on the line it
won't convert them to tabs when I ask it reindent things. That's a bit
strange. I'll go through the rest of the patches and try to fix that
up.
>
> Series Reviewed-by: Jordan Justen <jordan.l.justen@xxxxxxxxx>
Thanks.
>
> > test_progs += 'testdisplay'
> >
> > run_command('generate_testlist.sh', test_progs)
> > --
> > 2.13.5
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
