Re: [PATCH i-g-t 01/12] meson: Install tests into $libexecdir

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2017-09-11 10:24:56, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> 
> autotools installs the tests into $libexecdir. Make meson do the same.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> ---
>  tests/meson.build | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/meson.build b/tests/meson.build
> index 4dd5a9c9d4c7..1f98f2a02bb9 100644
> --- a/tests/meson.build
> +++ b/tests/meson.build
> @@ -255,13 +255,19 @@ if alsa.found() and gsl.found()
>         test_deps += alsa
>  endif
>  
> +libexecdir = join_paths(get_option('prefix'), get_option('libexecdir'), 'intel-gpu-tools')
> +
>  foreach prog : test_progs
>         executable(prog, prog + '.c',
> -                       dependencies : test_deps)
> +                  dependencies : test_deps,
> +                  install_dir : libexecdir,
> +                  install : true)
>  endforeach
>  
>  executable('testdisplay', ['testdisplay.c', 'testdisplay_hotplug.c'],
> -               dependencies : test_deps)
> +           dependencies : test_deps,
> +          install_dir : libexecdir,
> +          install : true)

I noticed indentation alignment issues, like this one, in many of the
patches. (Often when adding 'install : true')

Can you review and fix the alignment on all patches?

Series Reviewed-by: Jordan Justen <jordan.l.justen@xxxxxxxxx>

>  test_progs += 'testdisplay'
>  
>  run_command('generate_testlist.sh', test_progs)
> -- 
> 2.13.5
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux