> -----Original Message----- > From: Nikula, Jani > Sent: Wednesday, September 13, 2017 1:39 PM > To: Chauhan, Madhav <madhav.chauhan@xxxxxxxxx>; Srinivas, Vidya > <vidya.srinivas@xxxxxxxxx>; intel-gfx@xxxxxxxxxxxxxxxxxxxxx > Subject: RE: [PATCH] Revert "drm/i915/bxt: Disable device ready > before shutdown command" > > On Tue, 12 Sep 2017, "Chauhan, Madhav" <madhav.chauhan@xxxxxxxxx> > wrote: > >> -----Original Message----- > >> From: Intel-gfx [mailto:intel-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx] On > >> Behalf Of Vidya Srinivas > >> Sent: Tuesday, September 5, 2017 3:15 PM > >> To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx > >> Cc: Srinivas, Vidya <vidya.srinivas@xxxxxxxxx> > >> Subject: [PATCH] Revert "drm/i915/bxt: Disable device > >> ready before shutdown command" > >> > >> From: Uma Shankar <uma.shankar@xxxxxxxxx> > >> > >> This reverts commit bbdf0b2ff32aa75c7bd167569130e9391d2e6282. > >> > >> Disable device ready before shutdown command was added previously to > >> avoid a split screen issue seen on dual link DSI panels. As of now, > >> dual link is not supported and will need some rework in the upstream > >> code. For single link DSI panels, the change is not required. This > >> will cause failure in sending SHUTDOWN packet during disable. Hence > >> reverting the change. Will handle the change as part of dual link enabling > in upstream. > > > > Already there are lot of changes wrt to DSI dual link inside intel_dsi.c. > > Can't we keep this change as well under the condition if (dual_link && > Broxton)?? > > Might help to fetch dual link changes in future instead of losing it. > > I've pushed the patch as-is. I don't think there are grounds to keep it even > with dual_link. As Uma says, these things may be panel specific too. Hmm..Ok Thanks for clarification. Regards, Madhav > > BR, > Jani. > > > -- > Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx