Sorry for the delayed review, this series needs to rebased as we are passing crtc_state to a lot of these functions now. I don't see any issues based on my cursory review. On Wed, 2017-07-12 at 12:20 -0700, Rodrigo Vivi wrote: > Most of patches on this series is only a clean up with > no functional changes. The goal is to allow split VLV PSR > implementation better. In a way that would get more cleaner > when we use or not the hw tracking. > > The ones with actual functional changes are: > 0002-drm-i915-psr-Avoid-any-PSR-stuff-on-platforms-withou.patch > that protects PSR of running anything on the platforms without support. > > and > 0012-drm-i915-psr-Use-more-PSR-HW-tracking.patch > that allows us to use more HW tracking and consequently > a proper PSR2 with partial screen updates. > > Rodrigo Vivi (12): > drm/i915/psr: Remove vlv_is_active function. > drm/i915/psr: Avoid any PSR stuff on platforms without support. > drm/i915/psr: vfunc for disabling source. > drm/i915/psr: hsw_psr_activate. > drm/i915/psr: Add activate vfunc. > drm/i915/psr: Unify VSC setup functions. > drm/i915/psr: Re-create a hsw_psr_enable_source. > drm/i915/psr: Re-org Activate after enable > drm/i915/psr: Add setup VSC vfunc. > drm/i915/psr: Add enable_sink vfunc. > drm/i915/psr: Add enable_source vfunc. > drm/i915/psr: Use more PSR HW tracking. > > drivers/gpu/drm/i915/i915_drv.h | 7 + > drivers/gpu/drm/i915/intel_drv.h | 3 +- > drivers/gpu/drm/i915/intel_frontbuffer.c | 2 +- > drivers/gpu/drm/i915/intel_psr.c | 267 ++++++++++++++++--------------- > 4 files changed, 150 insertions(+), 129 deletions(-) > _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx