Op 31-08-17 om 20:48 schreef Ville Syrjälä: > On Wed, Aug 30, 2017 at 09:57:03PM +0300, ville.syrjala@xxxxxxxxxxxxxxx wrote: >> From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> >> >> Make the min_pixclk thing less confusing by changing it to track >> the minimum acceptable cdclk frequency instead. This means moving >> the application of the guardbands to a slightly higher level from >> the low level platform specific calc_cdclk() functions. >> >> The immediate benefit is elimination of the confusing 2x factors >> on GLK/CNL+ in the audio workarounds (which stems from the fact >> that the pipes produce two pixels per clock). >> >> v2: Keep cdclk higher on CNL to workaround missing DDI clock voltage handling >> v3: Squash with the CNL cdclk limits patch (DK) >> v4: s/intel_min_cdclk/intel_pixel_rate_to_cdclk/ (DK) >> >> Cc: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx> >> Cc: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> >> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@xxxxxxxxx> >> Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx> >> Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@xxxxxxxxx> >> Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > I didn't get any objections from the CNL camp, so I went ahead and > pushed the series. Thanks for the reviews. > I seem to have a WARN_ON during init now on my broadwell, likely related to this series? [ 13.105310] i915 0000:00:02.0: vgaarb: changed VGA decodes: olddecodes=io+mem,decodes=io+mem:owns=io+mem [ 13.132264] systemd-journald[159]: Successfully sent stream file descriptor to service manager. [ 13.161016] WARN_ON(min_cdclk < 0) [ 13.161078] ------------[ cut here ]------------ [ 13.161336] WARNING: CPU: 1 PID: 209 at drivers/gpu/drm/i915/intel_display.c:15070 intel_modeset_setup_hw_state+0x15a4/0x3000 [i915] [ 13.161517] Modules linked in: snd_seq_device snd_timer drbg i915(+) cfg80211 ecdh_generic(+) prime_numbers drm_kms_helper snd syscopyarea sysfillrect sysimgblt fb_sys_fops drm soundcore fan thermal i2c_designware_platform i2c_designware_core acpi_pad parport_pc ppdev parport autofs4 [ 13.161822] CPU: 1 PID: 209 Comm: systemd-udevd Tainted: G U 4.13.0-rc7-patser+ #5236 [ 13.161884] Hardware name: NUC5i7RYB, BIOS RYBDWi35.86A.0246.2015.0309.1355 03/09/2015 [ 13.161963] task: ffff8800cd054500 task.stack: ffff8800c6840000 [ 13.162083] RIP: 0010:intel_modeset_setup_hw_state+0x15a4/0x3000 [i915] [ 13.162393] RSP: 0018:ffff8800c68472a0 EFLAGS: 00010282 [ 13.162434] RAX: 0000000000000016 RBX: ffff8800c65d4c80 RCX: ffff8800cd054cd8 [ 13.162478] RDX: 0000000000000000 RSI: ffff8800cd054d78 RDI: ffff8800cd054cd4 [ 13.162521] RBP: ffff8800c68473e0 R08: 0000000000000000 R09: 0000000000000000 [ 13.162565] R10: ffff8800c65d4e57 R11: 0000000000000000 R12: dffffc0000000000 [ 13.162611] R13: ffff8800c8190000 R14: ffff8800c65d6f88 R15: ffff8800c65d6e80 [ 13.162654] FS: 00007fc3599c08c0(0000) GS:ffff8800d4e80000(0000) knlGS:0000000000000000 [ 13.162710] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 13.162750] CR2: 00007ffd657bffb8 CR3: 00000000cb477000 CR4: 00000000003406e0 [ 13.162794] Call Trace: [ 13.162911] ? intel_mode_from_pipe_config+0x560/0x560 [i915] [ 13.162975] ? drm_modeset_lock+0x162/0x270 [drm] [ 13.163036] ? drm_modeset_lock_all_ctx+0xf3/0x140 [drm] [ 13.163192] intel_modeset_init+0x327b/0x4720 [i915] [ 13.163316] ? intel_modeset_init_hw+0x160/0x160 [i915] [ 13.163431] i915_driver_load+0x2c50/0x3300 [i915] [ 13.163473] ? find_held_lock+0x36/0x1c0 [ 13.163579] ? __i915_printk+0x280/0x280 [i915] [ 13.163722] ? wait_for_completion_killable_timeout+0x430/0x430 [ 13.163775] ? mutex_unlock+0xd/0x10 [ 13.163809] ? acpi_dev_found+0xa7/0xb0 [ 13.163910] i915_pci_probe+0x108/0x180 [i915] [ 13.164011] ? i915_pci_remove+0x50/0x50 [i915] [ 13.164080] local_pci_probe+0xe8/0x160 [ 13.164120] pci_device_probe+0x3fe/0x580 [ 13.164190] ? pci_device_remove+0x1b0/0x1b0 [ 13.164230] ? _raw_spin_unlock+0x2c/0x40 [ 13.164271] driver_probe_device+0x2fb/0x670 [ 13.164313] ? driver_probe_device+0x670/0x670 [ 13.164352] __driver_attach+0xff/0x140 [ 13.164388] bus_for_each_dev+0x11b/0x1b0 [ 13.164675] ? store_drivers_autoprobe+0x120/0x120 [ 13.164719] ? _raw_spin_unlock+0x2c/0x40 [ 13.164759] driver_attach+0x45/0x50 [ 13.164791] bus_add_driver+0x2a2/0x520 [ 13.164832] driver_register+0x256/0x310 [ 13.164865] ? __raw_spin_lock_init+0x2d/0xf0 [ 13.164905] __pci_register_driver+0x192/0x1a0 [ 13.165013] i915_init+0xc8/0xd5 [i915] [ 13.165081] ? 0xffffffffc09e0000 [ 13.165114] do_one_initcall+0x121/0x204 [ 13.165206] ? initcall_blacklisted+0x160/0x160 [ 13.165245] ? kasan_unpoison_shadow+0x35/0x50 [ 13.165282] ? kasan_kmalloc+0xb6/0xd0 [ 13.165317] ? kasan_unpoison_shadow+0x35/0x50 [ 13.165355] ? __asan_register_globals+0x7c/0xa0 [ 13.165399] do_init_module+0x1b6/0x500 [ 13.165440] load_module+0x6f4b/0x85e0 [ 13.165501] ? module_frob_arch_sections+0x20/0x20 [ 13.165554] ? open_exec+0x40/0x40 [ 13.165601] SYSC_finit_module+0x110/0x180 [ 13.165635] ? SYSC_finit_module+0x110/0x180 [ 13.165672] ? SYSC_init_module+0x1e0/0x1e0 [ 13.165712] ? __secure_computing+0x204/0x220 [ 13.165751] ? syscall_trace_enter+0x531/0xcc0 [ 13.165800] ? do_syscall_64+0x47/0x350 [ 13.165832] ? SyS_init_module+0x10/0x10 [ 13.165864] SyS_finit_module+0x9/0x10 [ 13.165894] do_syscall_64+0x20a/0x350 [ 13.165930] entry_SYSCALL64_slow_path+0x25/0x25 [ 13.165964] RIP: 0033:0x7fc358845949 [ 13.165993] RSP: 002b:00007ffda5e44e08 EFLAGS: 00000246 ORIG_RAX: 0000000000000139 [ 13.166170] RAX: ffffffffffffffda RBX: 000055ab74c53830 RCX: 00007fc358845949 [ 13.166303] RDX: 0000000000000000 RSI: 000055ab74c53400 RDI: 0000000000000015 [ 13.166349] RBP: 000055ab74c53400 R08: 0000000000000000 R09: 000000000000002d [ 13.166577] R10: 0000000000000015 R11: 0000000000000246 R12: 0000000000000000 [ 13.166781] R13: 000055ab74c888e0 R14: 0000000000020000 R15: 0000000000000000 [ 13.166841] Code: 31 c0 49 83 bd e8 54 00 00 00 74 23 48 89 df e8 d3 12 fb ff 85 c0 79 17 48 c7 c6 20 1a 8c c0 48 c7 c7 60 a9 8b c0 e8 b7 d9 b1 ef <0f> ff 31 c0 48 8b b5 08 ff ff ff 4c 89 ff 89 85 20 ff ff ff e8 [ 13.167257] ---[ end trace 8bc55e2833d4ddb0 ]--- _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
