[PATCH] drm/i915: Don't set fence errors on non-guilty requests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



... at least not in that place, because this can also fire for
requests which have completed. Which then hits the assert in
dma_fence_set_error.

Since I'm not really clear what should be done here I pinged Chris,
and he suggested we simply remove this for now.

Found while stress-testing gpu reset using kms_busy, with about 0-3
hits of it per complete run on my snb here.

Testcase: igt/kms_busy.
Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
Cc: Mika Kuoppala <mika.kuoppala@xxxxxxxxx>
Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>
---
 drivers/gpu/drm/i915/i915_gem.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 1a8842f143fc..1c7453e2cc45 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -2955,7 +2955,6 @@ static bool i915_gem_reset_request(struct drm_i915_gem_request *request)
 		skip_request(request);
 	} else {
 		i915_gem_context_mark_innocent(request->ctx);
-		dma_fence_set_error(&request->fence, -EAGAIN);
 	}
 
 	return guilty;
-- 
2.13.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux