On Wed, 16 Nov 2011 17:05:50 +0100 Daniel Vetter <daniel at ffwll.ch> wrote: > On Mon, Nov 14, 2011 at 21:22, Jesse Barnes <jbarnes at virtuousgeek.org> wrote: > > To save power when the sprite is full screen, we can disable the primary > > plane on the same pipe. ?Track the sprite status and enable/disable the > > primary opportunistically. > > > > Signed-off-by: Jesse Barnes > > Imo the indirection is overkill because afaics there's no difference. > And in my experience this will only get in the way when later hw > _really_ needs some abstraction (*cough* intel_ringbuffer.c *cough*. > Can we just kill it? Yeah I can make ivb and snb share at least (and probably ilk), but I *do* have code coming that needs the separation. (At least I'm pretty sure; I'll remove the abstraction if it turns out I don't need it.) Thanks, -- Jesse Barnes, Intel Open Source Technology Center
