On Mon, Nov 14, 2011 at 21:22, Jesse Barnes <jbarnes at virtuousgeek.org> wrote: > The video sprites support various video surface formats natively and can > handle scaling as well. ?So add support for them using the new DRM core > sprite support functions. > > v2: use drm specific fourcc header and defines > v3: address Daniel's comments: > ?- don't take struct mutex around register access (only needed for > ? ?regs in the GT power well) > ?- don't hold struct mutex across vblank waits > ?- fix up update_plane API (pass obj instead of GTT offset) > ?- add interlaced defines for sprite regs > ?- drop unnecessary 'reg' variables > ?- comment double buffered reg flushing > ?Also fix w/h confusion when writing the scaling reg. > > For this version, I tested DPMS since it came up in the last review; > DPMS off/on works ok when a video player is working under X, but for > power saving we'll probably want to do something smarter. ?I'll leave > that for a separate patch on top. ?Likewise with the refcounting/fb > layer handling, which are really separate cleanups. > > Signed-off-by: Jesse Barnes <jbarnes at virtuousgeek.org> I haven't rechecked with Bspec (I'm not that insane ;-) but with my comments addressed, this looks good, and fixing dpms handling and framebuffer ugliness is something for another patch series. Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch> -- Daniel Vetter daniel.vetter at ffwll.ch - +41 (0) 79 364 57 48 - http://blog.ffwll.ch
