Re: [PATCH 4/5] drm/i915: Split the engine info table in two levels, using class + instance

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 04/06/2017 01:12 PM, Chris Wilson wrote:
On Thu, Apr 06, 2017 at 05:55:43AM -0700, Oscar Mateo wrote:
There are some properties that logically belong to the engine class, and some
that belong to the engine instance. Make it explicit.

v2: Commit message (Tvrtko)

Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
Cc: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx>
Cc: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>
Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx>
Signed-off-by: Oscar Mateo <oscar.mateo@xxxxxxxxx>
---
  drivers/gpu/drm/i915/intel_engine_cs.c | 72 +++++++++++++++++++++-------------
  1 file changed, 44 insertions(+), 28 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c
index 2409908..506ec952 100644
--- a/drivers/gpu/drm/i915/intel_engine_cs.c
+++ b/drivers/gpu/drm/i915/intel_engine_cs.c
@@ -26,71 +26,83 @@
  #include "intel_ringbuffer.h"
  #include "intel_lrc.h"
-static const struct engine_info {
+struct engine_class_info {
  	const char *name;
  	unsigned int exec_id;
Ugh. What??? Each engine will have a unique exec/uabi id.
-Chris
Ok, I'll move it back to the instance if it matches better the VLC load balancing work?
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux