On ke, 2017-03-29 at 00:01 +0000, Vivi, Rodrigo wrote: > On Tue, 2017-03-28 at 22:11 +0000, Srivatsa, Anusha wrote: > > > > +++ b/drivers/gpu/drm/i915/intel_guc_loader.c > > > > @@ -61,6 +61,9 @@ > > > > #define KBL_FW_MAJOR 9 > > > > #define KBL_FW_MINOR 14 > > > > > > > > +#define GLK_FW_MAJOR 10 > > > > +#define GLK_FW_MINOR 56 > > > > + > > > > #define GUC_FW_PATH(platform, major, minor) \ > > > > "i915/" __stringify(platform) "_guc_ver" __stringify(major) > > > > "_" __stringify(minor) ".bin" > > > > > > > > @@ -73,6 +76,8 @@ MODULE_FIRMWARE(I915_BXT_GUC_UCODE); > > > > #define I915_KBL_GUC_UCODE GUC_FW_PATH(kbl, KBL_FW_MAJOR, > > > > KBL_FW_MINOR) > > > > MODULE_FIRMWARE(I915_KBL_GUC_UCODE); > > > > > > > > +#define I915_GLK_GUC_UCODE GUC_FW_PATH(glk, GLK_FW_MAJOR, > > > > GLK_FW_MINOR) > > > > > > You need a line after this #define that says the following: > > > MODULE_FIRMWARE(I915_GLK_GUC_UCODE); > > > > Hi John, we have decided to not use it in pre-production platforms. > > Using MODULE_FIRMWARE is going to shout that the firmware is not > > available in systems. Since we will not be releasing the firmware > > binary to the public yet, it is unnecessary noise. > > +MODULE_FIRMARE() should be in a separated patch and only get merged > after the firmware got released at 01.org propagated and merged to > linux-firmware.git. Would it make a sense to put a big comment in the code at this spot? Pretty much what you wrote down. Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
