On Tue, 2017-03-28 at 17:01 -0700, Vivi, Rodrigo wrote: > On Tue, 2017-03-28 at 22:11 +0000, Srivatsa, Anusha wrote: > > > > > > > > > > -----Original Message----- > > > From: Spotswood, John A > > > Sent: Tuesday, March 28, 2017 2:35 PM > > > To: Srivatsa, Anusha <anusha.srivatsa@xxxxxxxxx>; intel- > > > gfx@xxxxxxxxxxxxxxxxxxxxx > > > Cc: Mcgee, Jeff <jeff.mcgee@xxxxxxxxx>; Vivi, Rodrigo <rodrigo.vi > > > vi@xxxxxxxxx> > > > Subject: Re: [PATCH 1/2] drm/i915/GuC/GLK: Load GuC on GLK > > > > > > > > > > @@ -73,6 +76,8 @@ MODULE_FIRMWARE(I915_BXT_GUC_UCODE); > > > > #define I915_KBL_GUC_UCODE GUC_FW_PATH(kbl, KBL_FW_MAJOR, > > > > KBL_FW_MINOR) > > > > MODULE_FIRMWARE(I915_KBL_GUC_UCODE); > > > > > > > > +#define I915_GLK_GUC_UCODE GUC_FW_PATH(glk, GLK_FW_MAJOR, > > > > GLK_FW_MINOR) > > > You need a line after this #define that says the following: > > > MODULE_FIRMWARE(I915_GLK_GUC_UCODE); > > > > > > Hi John, we have decided to not use it in pre-production platforms. > > Using MODULE_FIRMWARE is going to shout that the firmware is not > > available in systems. Since we will not be releasing the firmware > > binary to the public yet, it is unnecessary noise. > +MODULE_FIRMARE() should be in a separated patch and only get merged > after the firmware got released at 01.org propagated and merged to > linux-firmware.git. > Makes sense. My mistake. John _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
