On Fri, Mar 24, 2017 at 11:07:17AM +0200, Ville Syrjälä wrote:
> On Thu, Mar 23, 2017 at 05:07:28PM -0400, Sean Paul wrote:
> > Launch $EDITOR when extracting tags to curate the tags immediately. Once the
> > tags are proper, automatically add them before the first Signed-off-by line
> > to all patches in the range.
>
> Not sure adding them before the first sob is the right thing. If we want
> the tags to reflect the history somehow, then I suppose they should go
> just before *your* sob, which may or may not be the first sob in the
> commit message. Personally I've just started slapping them to the end
> which also maintains the history, but granted it doesn't really show who
> signed off on those tags. Or is there some "official" rule how tags
> should be sorted in commit messages?
Hi Ville,
Thanks for your review.
I usually sort them based on my perceived strength of the tag and put them
before the first SoB.
Cc:
Reviewed-by:
Tested-by:
Acked-by:
Signed-off-by:
I'm fine with putting them above the first SoB of the committer, that makes sense to
me. I'm not sure this is something we'll get consensus on, so that seems like a
sensible approach.
Sean
>
> And I don't like the $EDITOR idea either, so at least make it
> optional.
>
> >
> > Signed-off-by: Sean Paul <seanpaul@xxxxxxxxxxxx>
> > ---
> > dim | 13 ++++++++++---
> > 1 file changed, 10 insertions(+), 3 deletions(-)
> >
> > diff --git a/dim b/dim
> > index 43ea794..6a5580a 100755
> > --- a/dim
> > +++ b/dim
> > @@ -1145,6 +1145,12 @@ function rangeish()
> > fi
> > }
> >
> > +function insert_extracted_tags
> > +{
> > + new_tabs=`cat $1 | awk '{ORS="\\\\n"} {print $0}' | head -c-3`
> > + awk "/Signed-off-by/{p++} p==1{print \"$new_tabs\"; p++} p!=1{print}"
> > +}
> > +
> > function dim_extract_tags
> > {
> > local branch range file tags
> > @@ -1167,9 +1173,10 @@ function dim_extract_tags
> > return 0
> > fi
> >
> > - tags=$(printf -- "# *** extracted tags ***\n%s" "$tags")
> > -
> > - git filter-branch -f --msg-filter "cat ; echo \"$tags\"" $range
> > + echo "$tags" > $file
> > + $EDITOR $file
> > + export -f insert_extracted_tags
> > + git filter-branch -f --msg-filter "insert_extracted_tags $file" $range
> > }
> >
> > function dim_extract_queued
> > --
> > 2.12.1.500.gab5fba24ee-goog
>
> --
> Ville Syrjälä
> Intel OTC
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
