On pe, 2017-03-10 at 08:28 -0800, Oscar Mateo wrote: > Starting with intel_guc_loader, down to intel_guc_submission > and finally to intel_guc_log. > > v2: > - Null execbuf client outside guc_client_free (Daniele) > - Assert if things try to get allocated twice (Daniele/Joonas) > - Null guc->log.buf_addr when destroyed (Daniele) > - Newline between returning success and error labels (Joonas) > - Remove some unnecessary comments (Joonas) > - Keep guc_log_create_extras naming convention (Joonas) > - Helper function guc_log_has_extras (Joonas) > - No need for separate relay_channel create/destroy. It's just another extra. > - No need to nullify guc->log.flush_wq when destroyed (Joonas) > - Hoist the check for has_extras out of guc_log_create_extras (Joonas) > - Try to do i915_guc_log_register/unregister calls (kind of) symmetric (Daniele) > - Make sure initel_guc_fini is not called before init is ever called (Daniele) > > v3: > - Remove unnecessary parenthesis (Joonas) > - Check for logs enabled on debugfs registration > - Rebase on top of Tvrtko's "Fix request re-submission after reset" > > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx> > Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> > Signed-off-by: Oscar Mateo <oscar.mateo@xxxxxxxxx> Drop comments around the interrupt enabling/disabling that log is currently the only interrupt user. Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
