Re: [PATCH 3/3] drm/i915: No need to save/restore irq status in intel_engine_wakeup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 06/03/2017 15:11, Chris Wilson wrote:
On Mon, Mar 06, 2017 at 03:03:21PM +0000, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>

It is called from either the process or timer context so it is
correct to always disable interrupts.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>

All 3 look ok to me, I was uncertain about the timer context allowing
just a spin_lock_irq, but if lockdep is happy I was overly conservation.

Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>

Thanks, I've spotted those while starting to catch up with the some of the changes that landed while I wasn't 100% present.

Timers are softirq and lockdep is happy.

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux