On pe, 2017-03-03 at 18:18 +0000, Chris Wilson wrote:
> On Fri, Mar 03, 2017 at 06:03:34PM +0000, Matthew Auld wrote:
> >
> > It looks like we were incorrectly comparing vma->node against itself
> > instead of the target node, when evicting for a node on systems where we
> > need guard pages between regions with different cache domains. As a
> > consequence we can end up trying to needlessly evict neighbouring nodes,
> > even if they have the same cache domain, and if they were pinned we
> > would fail the eviction.
> >
> > Fixes: 625d988acc28 ("drm/i915: Extract reserving space in the GTT to a helper")
> > Signed-off-by: Matthew Auld <matthew.auld@xxxxxxxxx>
> > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
>
> Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> /o\
> -Chris
Good catch, will merge the series once the comments on patch 2 are
addressed.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
