On Wed, Mar 01, 2017 at 05:27:53PM +0000, Chris Wilson wrote: > On Wed, Mar 01, 2017 at 06:17:49PM +0100, Daniel Vetter wrote: > > This reverts commit 233ce881dd91fb13eb6b09deefae33168e6ead4c. > > > > I assumed it's ok, but really should have double-checked - CI caught > > tons of fail :( > > For the record, the failure comes from the error message in > intel_dp_get_link_train_fallback_values() as take the fallback path. As > userspace is informed, we don't need an *ERROR* at that point. > Should this be just a DEBUG_KMS instead of DRM_ERROR each time it fails link training since we are sending uevent to userspace for it to retry? That will make CI happy, but I think we still need to fix the real problem of eDP link failures on Port A for SKL. Regards Manasi > The really interesting question is why we are seeing link-training > failures in CI at all, and whether igt should be checking and reporting > link-status=BAD. > -Chris > > -- > Chris Wilson, Intel Open Source Technology Centre > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
