On Fri, Feb 17, 2017 at 02:39:35PM +0100, Michal Wajdeczko wrote: > On Fri, Feb 17, 2017 at 02:05:54PM +0100, Arkadiusz Hiler wrote: > > intel_uc_fw_fetch() is confusingly named in the light of recent changes. > > > > It's also in the worng place - 'guc_loader.h' - it's used for both guc > > Typo s/worng/wrong Done. > > and huc, which was reflected in name, but not it's location, so let's > > move it to 'intel_uc.c'. > > > > We can make a intel_uc_fw callback out of it, to avoid leaking it > > outside `intel_uc.c` > > Hmm, why do you think it is a problem to expose this function outside of intel_uc.c? > I can't see any real gain, rather unnecessary code complexity I was trying to figure out a good name for it (to not confuse it with intel_uc_fw_fetch) and maybe prefix it with __ to denote that nobody should really bother with it, but that's reserved for statics. I brought the topic on #intel-gfx and Joonas suggested this approach. That seems to be general trend with i915. -- Cheers, Arek _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
