Re: [PATCH 8/9] drm/i915/bxt: Enable BXT DSI dual link

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Nikula, Jani
> Sent: Tuesday, February 21, 2017 12:49 AM
> To: Hans de Goede <hdegoede@xxxxxxxxxx>; Srinivas, Vidya
> <vidya.srinivas@xxxxxxxxx>; Paauwe, Bob J <bob.j.paauwe@xxxxxxxxx>
> Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; Chauhan, Madhav
> <madhav.chauhan@xxxxxxxxx>
> Subject: Re:  [PATCH 8/9] drm/i915/bxt: Enable BXT DSI dual link
> 
> On Mon, 20 Feb 2017, Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> > Hi,
> >
> > On 20-02-17 12:00, Jani Nikula wrote:
> >> On Mon, 20 Feb 2017, "Srinivas, Vidya" <vidya.srinivas@xxxxxxxxx>
> wrote:
> >>> Thanks Jani. I will rebase and re-submit and also  to remove
> >>> drm_panel interface dependency, I am planning to create panel
> >>> sequence callbacks in intel_dsi structure itself. Is this approach okay?
> >>
> >> I think that's unnecessary overhead. I've come to think we should
> >> just do what Hans suggested in his patch [1]. It's easiest, and we
> >> don't really benefit anything from the drm_panel interface or
> >> function pointer chasing.
> >>
> >> Hans, do you think you'll have the time or motivation to refresh your
> >> series, or should we just let Vidya do this?
> >>
> >> As an added difficulty, there's Madhav doing the Geminilake enabling
> >> at the same time, and these two/three series [2][3][4] are bound to
> >> conflict to some extent.
> >
> > I've my series rebased in a personal repo. As I was planning on
> > resubmitting it at some point in the future. I can send out a new
> > version right now if you want ...
> 
> Vidya, see [1] for Hans' series. I'm inclined to pick (most of) that, and
> continue from there. Thoughts?
> 
> BR,
> Jani.

We went through Hans' series. 
http://www.mail-archive.com/intel-gfx@xxxxxxxxxxxxxxxxxxxxx/msg113101.html
We feel its okay to call the panel sequences directly instead of introducing
new call backs. We can use this approach. But, Hans' series has other changes
as well. For now, can we have only the generic sequence changes merged and
we will rebase our changes on top of that.

Regards
Vidya
> 
> 
> [1] http://mid.mail-archive.com/20170220140845.1714-1-
> hdegoede@xxxxxxxxxx
> 
> 
> --
> Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux