On Wed, 8 Feb 2017 16:20:54 +0530 Vidya Srinivas <vidya.srinivas@xxxxxxxxx> wrote: > From: Uma Shankar <uma.shankar@xxxxxxxxx> > > Fix the Sequence to program BXT DSI Latch and ULPS. > > Signed-off-by: Uma Shankar <uma.shankar@xxxxxxxxx> > Signed-off-by: Vidya Srinivas <vidya.srinivas@xxxxxxxxx> Reviewed-by: Bob Paauwe <bob.j.paauwe@xxxxxxxxx> > --- > drivers/gpu/drm/i915/intel_dsi.c | 23 +++++------------------ > 1 file changed, 5 insertions(+), 18 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c > index c297ea9..538755b 100644 > --- a/drivers/gpu/drm/i915/intel_dsi.c > +++ b/drivers/gpu/drm/i915/intel_dsi.c > @@ -366,32 +366,19 @@ static void bxt_dsi_device_ready(struct intel_encoder *encoder) > > DRM_DEBUG_KMS("\n"); > > - /* Exit Low power state in 4 steps*/ > + /* Enable MIPI PHY transparent latch */ > for_each_dsi_port(port, intel_dsi->ports) { > - > - /* 1. Enable MIPI PHY transparent latch */ > val = I915_READ(BXT_MIPI_PORT_CTRL(port)); > I915_WRITE(BXT_MIPI_PORT_CTRL(port), val | LP_OUTPUT_HOLD); > usleep_range(2000, 2500); > + } > > - /* 2. Enter ULPS */ > - val = I915_READ(MIPI_DEVICE_READY(port)); > - val &= ~ULPS_STATE_MASK; > - val |= (ULPS_STATE_ENTER | DEVICE_READY); > - I915_WRITE(MIPI_DEVICE_READY(port), val); > - /* at least 2us - relaxed for hrtimer subsystem optimization */ > - usleep_range(10, 50); > - > - /* 3. Exit ULPS */ > + /* Clear ULPS and set device ready */ > + for_each_dsi_port(port, intel_dsi->ports) { > val = I915_READ(MIPI_DEVICE_READY(port)); > val &= ~ULPS_STATE_MASK; > - val |= (ULPS_STATE_EXIT | DEVICE_READY); > I915_WRITE(MIPI_DEVICE_READY(port), val); > - usleep_range(1000, 1500); > - > - /* Clear ULPS and set device ready */ > - val = I915_READ(MIPI_DEVICE_READY(port)); > - val &= ~ULPS_STATE_MASK; > + usleep_range(2000, 2500); > val |= DEVICE_READY; > I915_WRITE(MIPI_DEVICE_READY(port), val); > } -- -- Bob Paauwe Bob.J.Paauwe@xxxxxxxxx IOTG / PED Software Organization Intel Corp. Folsom, CA (916) 356-6193 _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx