On ke, 2016-12-07 at 14:01 +0000, Chris Wilson wrote: > On Wed, Dec 07, 2016 at 03:49:39PM +0200, Joonas Lahtinen wrote: > > > > + WARN_ON(entry->domains & ~dev_priv->uncore.fw_domains); > > Ok, this is going to be hard to diagnose in the wild, how about > > WARN(entry->domains & ~fw_domains, > "Attempting to use register 0x%04x from uninitialised fw domain %x\n", > offset, entry->domains & ~fw_domains); ? That's an excellent idea. Although I'll call it "forcewake domain" for clarity. Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
