On Wed, Dec 07, 2016 at 03:49:39PM +0200, Joonas Lahtinen wrote: > Add WARN_ON to find_fw_domain to registers related to uninitialized > hardware. > > Cc: Imre Deak <imre.deak@xxxxxxxxx> > Cc: Wang Elaine <elaine.wang@xxxxxxxxx> > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > Signed-off-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> > --- > drivers/gpu/drm/i915/intel_uncore.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c > index 07779d0..b20b58e 100644 > --- a/drivers/gpu/drm/i915/intel_uncore.c > +++ b/drivers/gpu/drm/i915/intel_uncore.c > @@ -625,7 +625,12 @@ find_fw_domain(struct drm_i915_private *dev_priv, u32 offset) > dev_priv->uncore.fw_domains_table_entries, > fw_range_cmp); > > - return entry ? entry->domains : 0; > + if (!entry) > + return 0; > + > + WARN_ON(entry->domains & ~dev_priv->uncore.fw_domains); Ok, this is going to be hard to diagnose in the wild, how about WARN(entry->domains & ~fw_domains, "Attempting to use register 0x%04x from uninitialised fw domain %x\n", offset, entry->domains & ~fw_domains); ? -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
