On Tue, Nov 15, 2016 at 12:47:31PM +0100, Daniel Vetter wrote: > On Tue, Nov 15, 2016 at 10:42:08AM +0000, Chris Wilson wrote: > > On Mon, Nov 14, 2016 at 12:58:16PM +0100, Daniel Vetter wrote: > > > diff --git a/drivers/gpu/drm/drm_dumb_buffers.c b/drivers/gpu/drm/drm_dumb_buffers.c > > > new file mode 100644 > > > index 000000000000..4b4364b61c8d > > > --- /dev/null > > > +++ b/drivers/gpu/drm/drm_dumb_buffers.c > > > @@ -0,0 +1,135 @@ > > > +/* > > > + * Copyright (c) 2016 Intel Corporation > > > > I've mentioned this elsewhere, but we should also retain the original > > copyright statements for the code we are copying. > > Given that we're super-not-dutiful with updating them I figured point at > git log with rename detection is good enough. But fixed (same for the > later ones). I agree that git gives more traceablity to authorship (if not necessarily to whom that author has transfered the copyright for the work), but I feel if we are adding a blanket copyright clause we should recognise the validity of the earlier ones as well. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx