On Thu, Sep 29, 2016 at 04:35:43PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> > > A bunch of cleaned up patches from one of my old branches. Just an idea I had > been toying about and probably more a RFC at this point. But it amazingly > passed trybot on (almost) the first try so I got tempted to post it. > > Basically main motivation was to replace linear search comparison ladders in > all mmio accessors with something smarter - a binary search in this case. > > Main enabler is moving the comparison ladders from the code into the data > tables. Then gradually, patch by patch, I was able to reduce the code and > end up with a total saving of approximately 14KiB for the series. > > That is kind of nice, but whether the churn is worth it I leave open for > dicussion. It is slightly less code so perhaps more maintainable. Although > tastes will probably differ. More declarative approach, yes please. Looks really nice. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
