Re: [PATCH] drm/i915: Keep track of active forcewake domains in a bitmask

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 9/27/2016 6:51 PM, Tvrtko Ursulin wrote:

On 27/09/2016 13:26, Chris Wilson wrote:
On Tue, Sep 27, 2016 at 01:11:50PM +0100, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>

There are current places in the code, and there will be more in the
future, which iterate the forcewake domains to find out which ones
are currently active.

To save them from doing this iteration, we can cheaply keep a mask
of active domains in dev_priv->uncore.fw_domains_active.

This has no cost in terms of object size, even manages to shrink it
overall by 368 bytes on my config.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
Cc: "Paneri, Praveen" <praveen.paneri@xxxxxxxxx>
Looks solid and should not run afoul of the games played during reset or
suspend.

Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>

Thanks!

Praveen, you can see if this patch would help for your decoupled MMIO
patches, and if you like it you can incrorporate it in your series if
you want?
Thanks for the patch Tvrtko! I can definitely use it :)

Regards,

Tvrtko

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux