Re: [PATCH 4/8] drm/i915/gen9: fix the WaWmMemoryReadLatency implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Op 07-09-16 om 02:52 schreef Paulo Zanoni:
> Bspec says:
>   "The mailbox response data may not account for memory read latency.
>    If the mailbox response data for level 0 is 0us, add 2 microseconds
>    to the result for each valid level."
>
> This means we should only do the +2 in case wm[0] == 0, not always.
>
> So split the sanitizing implementation from the WA implementation and
> fix the WA implementation.
>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx>
This one probably needs a dim fixes $commit, just like patch 6 and 7.

For the rest the changes look sane, so with the review comments in the other patches addressed:
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux