On ti, 2016-07-26 at 09:12 +0100, Chris Wilson wrote: > On Tue, Jul 26, 2016 at 08:02:25AM +0300, Joonas Lahtinen wrote: > > > > On ma, 2016-07-25 at 18:31 +0100, Chris Wilson wrote: > > > > > > A few places we use ring when referring to the struct intel_engine_cs. An > > > anachronism we are pruning out. > > > > > > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > > > Link: http://patchwork.freedesktop.org/patch/msgid/1469432687-22756-9-git-send-email-chris@xxxxxxxxxxxxxxxxxx > > > --- > > > drivers/gpu/drm/i915/i915_gem.c | 24 ++++++++++++------------ > > > 1 file changed, 12 insertions(+), 12 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c > > > index e155e8dd28ed..7bfce1d5c61b 100644 > > > --- a/drivers/gpu/drm/i915/i915_gem.c > > > +++ b/drivers/gpu/drm/i915/i915_gem.c > > > @@ -46,7 +46,7 @@ static void i915_gem_object_flush_cpu_write_domain(struct drm_i915_gem_object *o > > > static void > > > i915_gem_object_retire__write(struct drm_i915_gem_object *obj); > > > static void > > > -i915_gem_object_retire__read(struct drm_i915_gem_object *obj, int ring); > > > +i915_gem_object_retire__read(struct drm_i915_gem_object *obj, int engine); > > I vote for engine_idx variable name, that much I dislike differing > > naming in signature and implementation. > I think engine_idx is pretty repugnant. I'll wait until you get to > "Refactor activity tracking for requests" so you see how this function > looks closer to its final form (in this series at least). Ok, the parameter completely changes (into request), so no need to debate really. So have my; Reviewed-by: Joonas Lahtien <joonas.lahtinen@xxxxxxxxxxxxxxx> CC'ing Dave here too. Regards, Joonas > -Chris > -- Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
