On Wed, Dec 07, 2011 at 12:29:22PM -0800, Jesse Barnes wrote:
> Add new ioctls for getting and setting the current destination color
> key. This allows for simple overlay display control by matching a color
> key value in the primary plane before blending the overlay on top.
>
> v2: remove unnecessary mutex acquire/release around reg accesses
>
> Signed-off-by: Jesse Barnes <jbarnes at virtuousgeek.org>
[snip]
> +/* Set the destination color key on a given sprite */
> +struct drm_intel_set_sprite_destkey {
> + __u32 plane_id;
> + __u32 value;
> +};
> +
> +/* Get the current destination color key on a given sprite */
> +struct drm_intel_get_sprite_destkey {
> + __u32 plane_id;
> + __u32 value;
> +};
As explained in my top-reply, I think we want a __u32 flags here to
enable the colorkey (and maybe switch between dst/src color key). Nothing
else to complain about here.
-Daniel
--
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48
