Reviewer: Ines Robles Review result: Has Nits Review type: rtgdir - Telechat review Requested version for review: 20 Deadline: 2020-04-15 Reviewer: Ines Robles Summary: This document defines a Border Gateway Protocol Network Layer Reachability Information (BGP NLRI) encoding format that can be used to distribute traffic Flow Specifications. It also specifies BGP Extended Community encoding formats. This document obsoletes both RFC5575 and RFC7674. I found the document clear and complete. Some minor nits are detailed below. Major issues: Not found Minor issues: Not found Nits: 1- In the Introduction, it would be nice to mention how this draft obsoletes RFC7674 and point to appendix B when referring obsoleting RFC5575. For example, This document obsoletes "Dissemination of Flow Specification Rules" [RFC5575], whose differences can be found in Appendix B. This document obsoletes also "Clarification of the Flowspec Redirect Extended Community"[RFC7674] due to this document includes..... - please expand iBGP --> Internal BGP (iBGP) 2- Section 4.2.1.1 in "a - AND bit:..." 2.1 - "the previous term" refers to a component? 2.2 -nit: "...unset and and MUST..." => "...unset and MUST..." 3-nit Section 5: "...this draft specifies..." if it becomes RFC it would be nice to read "..this document specifies.." Thanks for this document, Ines. -- last-call mailing list last-call@xxxxxxxx https://www.ietf.org/mailman/listinfo/last-call
