On Fri, 2018-05-04 at 02:08 +0000, Dongjie (Jimmy) wrote: > Hi Lada, > > Thanks a lot for your review comments. Please see some replies inline: > > > -----Original Message----- > > From: Ladislav Lhotka [mailto:lhotka@xxxxxx] > > Sent: Wednesday, May 02, 2018 9:32 PM > > To: yang-doctors@xxxxxxxx > > Cc: i2rs@xxxxxxxx; ietf@xxxxxxxx; > > draft-ietf-i2rs-yang-l2-network-topology.all@xxxxxxxx > > Subject: Yangdoctors early review of draft-ietf-i2rs-yang-l2-network- > > topology-04 > > > > Reviewer: Ladislav Lhotka > > Review result: Ready > > > > This draft and YANG modules contained therein fit into the framework of I2RS > > network topology models. I have no substantial comments, from the YANG point > > of view this document is ready to be published. > > > > Comments and questions: > > > > 1. What is the purpose of the 'flag-type' type and 'flag-identity' identity? > > There are no identities derived from the latter. > > The "flag-type" type is used in the grouping "l2-network-attributes", "l2- > node-attributes" and "l2-link-attributes". > > While there is no identities derived from the "flag-identity", it is used in > the typedef flag-type. Is this OK? >From the YANG point of view it is certainly OK. Do you expect other modules to define identities derived from "flag-identity"? > > > 2. Some descriptions overuse capitalization. For example, instead of 'VLAN > > Name' > > I would suggest 'VLAN name'. > > Thanks for catching this. Will fix in next revision. > > > 3. An example of an instance document in an appendix would be very helpful. > > Thanks for your suggestion. We will add an example to the appendix. Thanks, Lada > > Best regards, > Jie > -- Ladislav Lhotka Head, CZ.NIC Labs PGP Key ID: 0xB8F92B08A9F76C67
