Mahesh
Getting there.
I still cannot find a Reference in the I-D for RFC 2330 which appears in
the module.
'max-count' I still find open to confusion - I was hoping that you would
rename the leaf, and not the grouping, since it is the leaf, the data
object, that is an exponent. Further down, you have
"The default
max-count value SHOULD be 32768.'
"
which I think wrong since the leaf is and was an exponent. After
renaming the leaf, not the grouping, I was expecting something like
'The default value of max-count-exponent SHOULD be 15 which corresponds
to a maximum value of 2**15 i.e.32768.'
On the presence/ boolean, and top level nodes being mandatory true, your
solution looks fine (I said to you that my knowledge of YANG was limited
and while this restriction has a faint echo in my memory, I cannot find
the paragraph in RFC6020/RFC7950 that spells this out:-(
I am still thinking about secret key.
Tom Petch
----- Original Message -----
From: "Mahesh Jethanandani" <mjethanandani@xxxxxxxxx>
To: "tom p." <daedulus@xxxxxxxxxxxxx>
Cc: <ietf@xxxxxxxx>; <ippm-chairs@xxxxxxxx>;
<draft-ietf-ippm-twamp-yang@xxxxxxxx>; <ippm@xxxxxxxx>
Sent: Monday, April 16, 2018 3:58 PM
Tom,
On this particular comment ….
> On Apr 12, 2018, at 5:13 PM, Mahesh Jethanandani
<mjethanandani@xxxxxxxxx> wrote:
>
>>
>>
>> "container session-sender {
>> if-feature session-sender;
>> presence "Enables TWAMP Session-Sender functionality.";
>> description
>> "Configuration of the TWAMP Session-Sender logical entity";
>> leaf admin-state {
>> type boolean;
>> mandatory true;
>> description
>> "Indicates whether the device is allowed to operate
>> as a TWAMP Session-Sender.";
>> "
>>
>> A presence container is a boolean so I am unclear what it is that the
>> admin-state boolean adds here since the presence container "Enables
>> TWAMP Session-Sender functionality.”;
>
> [mj] Good catch. Will remove the presence statement.
[[mj]] In addition to removing the presence statement, we decided to
change the ‘mandatory true' statement to a ‘default true’ statement.
Just removing the presence statement results in the following error:
Validating yang/ietf-twamp@xxxxxxxxxxxxxxx
<mailto:yang/ietf-twamp@xxxxxxxxxxxxxxx>
yang/ietf-twamp@xxxxxxxxxxxxxxx
<mailto:yang/ietf-twamp@xxxxxxxxxxxxxxx>:445: error: RFC 6087: 4.9:
top-level node twamp must not be mandatory
Cheers.
Mahesh Jethanandani
mjethanandani@xxxxxxxxx
