Hi, Med and Michal, Thanks for your review, the authors have submitted a new version (https://datatracker.ietf.org/doc/html/draft-ietf-netmod-system-config-07) to resolve the nits you raised below, together with some other updates received from the WG. Please review the diff (https://author-tools.ietf.org/iddiff?url1=draft-ietf-netmod-system-config-06&url2=draft-ietf-netmod-system-config-07&difftype=--html) and let us know if you have further comments. Thanks a lot! Best Regards, Qiufang -----Original Message----- From: mohamed.boucadair@xxxxxxxxxx [mailto:mohamed.boucadair@xxxxxxxxxx] Sent: Thursday, June 13, 2024 7:25 PM To: Michal Vaško <mvasko@xxxxxxxxx>; yang-doctors@xxxxxxxx Cc: draft-ietf-netmod-system-config.all@xxxxxxxx; last-call@xxxxxxxx; netmod@xxxxxxxx Subject: RE: [netmod] Yangdoctors last call review of draft-ietf-netmod-system-config-06 Hi all, On this one: > - all 'local-as' and 'peer-as' nodes are uint32, so in JSON encoding > numbers should be used instead of strings Even if this an example, the authors may consider using "inet:as-number" rather than uint32. As I'm there, (1) the name of this leaf is weird: leaf name { type inet:ip-address; } I would change the name. (2) I would delete from the description of the ietf-system-datastore module: The key words 'MUST', 'MUST NOT', 'REQUIRED', 'SHALL', 'SHALL NOT', 'SHOULD', 'SHOULD NOT', 'RECOMMENDED', 'NOT RECOMMENDED', 'MAY', and 'OPTIONAL' in this document are to be interpreted as described in BCP 14 (RFC 2119) (RFC 8174) when, and only when, they appear in all capitals, as shown here."; (3) Please fix this part in the IANA cons: OLD: name: ietf-system-datastore prefix: sys NEW: name: ietf-system-datastore prefix: sysds (4) Security cons: Please use the sec template in both subsections For example, CURRENT: The Network Configuration Access Control Model (NACM) [RFC8341] provides the means to restrict access for particular NETCONF users to a preconfigured subset of all available NETCONF protocol operations and content. Does not mention RESTCONF. I think other para of the template should make it to these sections. Also, you may start each subsection by indicating the name of the module instead of "The YANG module defined in this document" because two modules are defined in the doc. Hope this helps. Cheers, Med > -----Message d'origine----- > De : Michal Vaško via Datatracker <noreply@xxxxxxxx> Envoyé : jeudi 13 > juin 2024 12:25 À : yang-doctors@xxxxxxxx Cc : > draft-ietf-netmod-system-config.all@xxxxxxxx; last- call@xxxxxxxx; > netmod@xxxxxxxx Objet : [netmod] Yangdoctors last call review of > draft-ietf- > netmod-system-config-06 > > > Reviewer: Michal Vaško > Review result: Ready with Nits > > This is my yang-doctor review of draft-ietf-netmod-system-config, > which includes 2 small YANG modules, in addition to a few example > modules. > > ietf-system-datastore: > - small module with a single identity, no issues > > ietf-netconf-resolve-system: > - module with similar simple augments to standard ietf-netconf and > ietf-netconf-nmda modules, no issues > > As for the example YANG modules and data, there are a few nits: > > example-acl: > - leaf-list application - path is not indented > > Section 8.2 BGP examples: > - 'inet:port' type does not exist in the latest ietf-inet-types > (2013) YANG module, only 'port-number' - all 'local-as' and 'peer-as' > nodes are uint32, so in JSON encoding numbers should be used instead > of strings - 'local-port' is using uint16 type so in JSON encoding > numbers should be used instead of strings > > Finally, the examples and their data are using YANG snippets and data > without namespaces or module names, which may be fine for illustration > purposes but possibly confusing. > > > _______________________________________________ > netmod mailing list -- netmod@xxxxxxxx To unsubscribe send an email to > netmod-leave@xxxxxxxx ____________________________________________________________________________________________________________ Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci. This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation. If you have received this email in error, please notify the sender and delete this message and its attachments. As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified. Thank you. -- last-call mailing list -- last-call@xxxxxxxx To unsubscribe send an email to last-call-leave@xxxxxxxx
