Reviewer: Michal Vaško Review result: Ready with Nits This is my yang-doctor review of draft-ietf-netmod-system-config, which includes 2 small YANG modules, in addition to a few example modules. ietf-system-datastore: - small module with a single identity, no issues ietf-netconf-resolve-system: - module with similar simple augments to standard ietf-netconf and ietf-netconf-nmda modules, no issues As for the example YANG modules and data, there are a few nits: example-acl: - leaf-list application - path is not indented Section 8.2 BGP examples: - 'inet:port' type does not exist in the latest ietf-inet-types (2013) YANG module, only 'port-number' - all 'local-as' and 'peer-as' nodes are uint32, so in JSON encoding numbers should be used instead of strings - 'local-port' is using uint16 type so in JSON encoding numbers should be used instead of strings Finally, the examples and their data are using YANG snippets and data without namespaces or module names, which may be fine for illustration purposes but possibly confusing. -- last-call mailing list -- last-call@xxxxxxxx To unsubscribe send an email to last-call-leave@xxxxxxxx
