Hi Job, On 2 Nov 2023, at 19:03, Job Snijders wrote: > Dear Jim, > > Thank you for taking the time to review this document! > > On Mon, Oct 16, 2023 at 10:12:05PM -0700, Jim Fenton via Datatracker wrote: >> 2. Section 4.3.2 says that ROAIPAddress contains IPAddress elements >> while (if I'm reading the definition correctly) it contains BIT STRING >> elements. RFC 6482 defined an IPAddress element as a BIT STRING but >> that definition was removed; perhaps the text didn't keep up with >> that. > > I think the 'BIT STRING' you are looking for is present via the > 'ROAIPAddress' -> 'address' definition. Previously the 'BIT STRING' was > an unconstrained definition, in this -bis document its bounded by the > maximum possible length which is dependent on whether the contained > address is IPv4 or IPv6, done like this 'BIT STRING (SIZE(0..len))'. The size bound on the ROAIPAddress is a good enhancement. But in RFC 6482, there was an element explicitly defined called IPAddress which was defined as a BIT STRING. But in this draft, I find no element named IPAddress, and I’m concerned with the fact that the text in Sec. 4.3.1 refers to IPAddress. > >> 3. RFC 4291 may be a normative reference due to the MUST NOT in Section 4.3.1. > > I moved the RFC4291 reference from the informative to the normative > reference section. > >> 4. I couldn't understand how to do the comparison in Sections 4.3.3 >> and 4.3.3.1. Specifically, what is the precedence between >> afi/addr/plen/mlen? It seems like that might be the order, but I don't >> see it specified anywhere (other than perhaps in the example >> implementations, which are informative). > > I am not 100% sure what exactly you are looking for. I don't think the > order in which to test the equivalence of the afi/addr/plen/mlen data > elements matters. Can you please elaborate? Made up example: Suppose two entries have the same plen and mlen. Entry A has a lower afi and entry B has a lower addr. Which comes first? -Jim -- last-call mailing list last-call@xxxxxxxx https://www.ietf.org/mailman/listinfo/last-call
