Re: [Patch] thinkpad_acpi: fix a build error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 25 Dec 2009, Takashi Iwai wrote:
> > "depends on SND || SND = n" takes care of the technical restrictions.
> 
> Yep, that's what I mentioned as Kconfig dependency :)

I think I will do it a bit different, so that you can opt-out ALSA support
and still have thinkpad-acpi built in, with modular ALSA in that case.

Which means that, due to the lack of "depends-but-not-hide", the
"thinkpad-acpi alsa support" kconfig entry will still just disappear due to
a "depends on SND && SND = THINKPAD_ACPI".

I really want a depends that leaves the entry still visible, but greyed out
:-(

> > The warning will be there.  Although I don't warn of missing rfkill
> > functionality if the kernel is missing the rfkill subsystem...
> 
> The messages could be KERN_INFO instead of KERN_WARNING, I think.

It is at KERN_NOTICE right now.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
_______________________________________________
ibm-acpi-devel mailing list
ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel

[Index of Archives]     [Linux ACPI]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Photo]     [Yosemite Photos]     [Yosemite Advice]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux