Re: [Patch] thinkpad_acpi: fix a build error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 23 Dec 2009, Takashi Iwai wrote:
> At Tue, 22 Dec 2009 17:38:58 -0200,
> Henrique de Moraes Holschuh wrote:
> > I won't in this case. I think I will cook up a patch to disable the entire
> > mixer subsystem in thinkpad-acpi if CONFIG_SND is not available.  I don't
> > like the depends on SND though.
> 
> That's also not so trivial unless you give any dependency in Kconfig.
> Without a restriction, THINKPAD_ACPI=y and SND=m can be chosen.

"depends on SND || SND = n" takes care of the technical restrictions.

I am testing the patch now.  No ALSA, no volume subdriver, module still
works (and prints some crap to syslog so that the user knows the driver
could do more with ALSA support).

> It'd be also not nice if suddenly a certain functionality disappears
> without warning (even if the subsystem is enabled but as a module).

The warning will be there.  Although I don't warn of missing rfkill
functionality if the kernel is missing the rfkill subsystem...

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
_______________________________________________
ibm-acpi-devel mailing list
ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel

[Index of Archives]     [Linux ACPI]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Photo]     [Yosemite Photos]     [Yosemite Advice]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux