Re: [Patch] thinkpad_acpi: fix a build error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 21 Dec 2009 14:38:56 -0800 Marcel Holtmann wrote:

> Hi Henrique,
> 
> > > The patch isn't correct (I guess the upstream fix is same?).
> > > 
> > > CONFIG_SOUND is a global config for sound subsystem.  The relevant
> > > functions are ALSA core part, which is CONFIG_SND.
> > > So, the fix should be:
> > > 
> > > 	depends on SND
> > > 
> > > instead.
> > 
> > Indeed.  Ingo already fixed that too.
> > 
> > Although I personally would prefer:
> > select SOUND
> > select SND
> > 
> > But anything that stops the build errors will do for now.
> 
> I still haven't seen this patch in Linus' tree. And you do need select
> SOUND and SND. Otherwise you still get build errors. I have tested this
> on my machine. So can someone please submit a proper patch to get this
> fixed.

Ugh.  Please don't 'select' to build an entire subsystem.

---
~Randy

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
_______________________________________________
ibm-acpi-devel mailing list
ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel

[Index of Archives]     [Linux ACPI]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Photo]     [Yosemite Photos]     [Yosemite Advice]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux