On Mon, 04 May 2009, Damjan Georgievski wrote: > > I've added a little extra functionality to this. The first is to send > > notifications whenever the mixer volume changes. These are via ALSA and > > simply allow other applications to know when the volume has changed. > > Henrique, I wasn't sure about the cleanest way to do this - we need to > > unmask the volume keys, and the easiest thing to do there was to simply > > change them to KEY_UNKNOWN. The problem with this is that they then > > generate ugly kernel messages. Not sure what the best thing to do here > > is - I guess I could just mangle the mask directly if ALSA_VOL is > > enabled. > > How about defining new KEY_NOTIFY_VOLUMEDOWN KEY_NOTIFY_VOLUMEUP and > use those for thinkpads and possibly others that have a hardware > mixer? How about not abusing the input layer like that? That would never get past me unless I was piss-poor drunk, and even then, it would be rejected by the input layer maintainer which is unlikely to be drunk at the same time I am :-) I will just add an extra filter layer to thinkpad-acpi, have the events always enabled in the firmware, trap them to notify ALSA and whatever else needs notifying, and forward them to the input device and legacy ACPI procfs only if the proper bits are set in the hotkey_mask. It is the proper way to do things, even if it is a bit more work. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh ------------------------------------------------------------------------------ The NEW KODAK i700 Series Scanners deliver under ANY circumstances! Your production scanning environment may not be a perfect world - but thanks to Kodak, there's a perfect scanner to get the job done! With the NEW KODAK i700 Series Scanner you'll get full speed at 300 dpi even with all image processing features enabled. http://p.sf.net/sfu/kodak-com _______________________________________________ ibm-acpi-devel mailing list ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
